Re: [PATCH s6-networking 1/1] Close a read end of a handshake notification pipe

From: Laurent Bercot <>
Date: Tue, 30 Aug 2022 11:00:03 +0000

>The write end of the pipe is closed when envs are written, therefore it
>make sense to close read end as well after envs are read. This prevents
>fd leaking to the app.

  Good catch, thanks. Applied with a little modification: since close()
can set errno, it shouldn't be called between read() and
strerr_diefu1sys() (which reads errno).

  Not going to cut a release just for this, because the bug is minor
(the leaked fd is completely unusable).

Received on Tue Aug 30 2022 - 13:00:03 CEST

This archive was generated by hypermail 2.4.0 : Tue Aug 30 2022 - 13:00:32 CEST