Re: Re[2]: skawares Failt to build if the CFLAGS are not in the same line

From: Sertonix <sertonix_at_posteo.net>
Date: Mon, 24 Mar 2025 18:20:16 +0000

The issues seem to be that ./configure is setting IFS=' ' without
unsetting the value again. This means tabs in CFLAGS also break
./configure. And the variables aren't escaped for config.mk.

This is not a proper patch only a proof of concept to fix the build of
skalibs with newlines in CFLAGS:

--- a/configure
+++ b/configure
_at__at_ -59,12 +59,10 _at__at_ EOF
 # generally not a good idea to use echo.
 # See http://etalabs.net/sh_tricks.html
 echo () {
- IFS=' '
   printf %s\\n "$*"
 }
 
 echon () {
- IFS=' '
   printf %s "$*"
 }
 
_at__at_ -133,8 +131,7 _at__at_ iscached ()
   if test -r "$tmps" && grep -q "^${1}: " "$tmps" ; then
     grep "^${1}: " "$tmps" | tail -n 1 |
     {
- IFS=' '
- read -r k v ldlibs
+ IFS=' ' read -r k v ldlibs
       if test -n "$ldlibs" ; then
         echo " ... user-provided: $v with linker args: $ldlibs"
         echo "$ldlibs" >&3
_at__at_ -705,7 +702,9 _at__at_ CC := ${CC_AUTO}
 CPPFLAGS_AUTO := $CPPFLAGS_AUTO
 CPPFLAGS := $CPPFLAGS $CPPFLAGS_POST
 CFLAGS_AUTO := $CFLAGS_AUTO
-CFLAGS := $CFLAGS $CFLAGS_POST
+CFLAGS := $CFLAGS ${CFLAGS_POST//'
+'/'\
+'}
 LDFLAGS_AUTO := $LDFLAGS_AUTO
 LDFLAGS := $LDFLAGS $LDFLAGS_POST
 LDFLAGS_NOSHARED := $LDFLAGS_NOSHARED
Received on Mon Mar 24 2025 - 19:20:16 CET

This archive was generated by hypermail 2.4.0 : Mon Mar 24 2025 - 19:20:49 CET